Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #2486 - ensure facts import is idempotent when values are unchanged #604

Closed
wants to merge 1 commit into from
Closed

fixes #2486 - ensure facts import is idempotent when values are unchanged #604

wants to merge 1 commit into from

Conversation

domcleal
Copy link
Contributor

three fixes:

  • calling ['name'] wasn't returning the associated name, needed to do .name
  • we compared ["value"] from the DB against "value" from the hash
  • we compared "1234" from the DB against 1234 integers from the hash (e.g. uptime)

@GregSutcliffe
Copy link
Member

Tests pass, and the code makes sense to me. 👍

@ohadlevy
Copy link
Member

merged - thanks

@ohadlevy ohadlevy closed this May 12, 2013
cfouant pushed a commit to cfouant/foreman that referenced this pull request Dec 18, 2018
@stbenjam
NFS shared folder support in Forklift (theforeman#604)
fa3fa4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domcleal @GregSutcliffe @ohadlevy