Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25600 - Migrate Icon to patternfly-react #6296

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Fixes #25600 - Migrate Icon to patternfly-react #6296

merged 1 commit into from
Dec 26, 2018

Conversation

orrabin
Copy link
Member

@orrabin orrabin commented Dec 2, 2018

Remove Icon from foreman
Switch DocumentLinkContent to use patternfly-react Icon

@theforeman-bot
Copy link
Member

Issues: #25600

amirfefer
amirfefer previously approved these changes Dec 2, 2018
View reviewed changes
Copy link
Member

@amirfefer amirfefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orrabin !
Works well 👍
I just wonder why patternfly design lacks with this question mark icon? how about open an issue/suggestion to patternfly react?

sharvit
sharvit approved these changes Dec 2, 2018
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @orrabin 👍

@sharvit
Copy link
Contributor

sharvit commented Dec 2, 2018

I just wonder why patternfly design lacks with this question mark icon? how about open an issue/suggestion to patternfly react?

@amirfefer I don't think it is about lack of design. I guess we just decided we want a button that link to the documentations and our documentation-button uses question-sign.

@amirfefer
Copy link
Member

@sharvit, as we discussed it earlier, the documentation button (in empty state component) is a link, not a button. so I would remove the question mark icon from it.

sharvit
sharvit suggested changes Dec 3, 2018
View reviewed changes
...ets/javascripts/react_app/components/common/EmptyState/__snapshots__/EmptyState.test.js.snap Outdated
@@ -58,7 +58,8 @@ exports[`Default Empty State should render documentation when given a url 1`] =
target="_blank"
>
<span
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, there is no reason to have Icon here.
@orrabin can remove the Icon from the EmptyState please?

waldenraines
waldenraines reviewed Dec 3, 2018
View reviewed changes
Copy link

@waldenraines waldenraines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, thanks @orrabin!

webpack/assets/javascripts/react_app/components/common/DocumentationLink/index.js
@@ -1,13 +1,12 @@
import React from 'react';
import PropTypes from 'prop-types';
import { MenuItem } from 'patternfly-react';
import Icon from '../Icon';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the Icon component itself?

Copy link
Member Author

@orrabin orrabin Dec 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the Icon folder. What else should be removed?

sharvit
sharvit previously approved these changes Dec 9, 2018
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @orrabin 👍

amirfefer
amirfefer suggested changes Dec 9, 2018
View reviewed changes
Copy link
Member

@amirfefer amirfefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orrabin 👍
Can we deleteDocumentationLink component after we removed it from its consumer?

webpack/assets/javascripts/react_app/components/common/DocumentationLink/index.js Outdated
@@ -1,13 +1,12 @@
import React from 'react';
import PropTypes from 'prop-types';
import { MenuItem } from 'patternfly-react';
import Icon from '../Icon';
import { MenuItem, Icon } from 'patternfly-react';
import { newWindowOnClick } from '../../../common/helpers';
import { translate as __ } from '../../../../react_app/common/I18n';

export const DocumentLinkContent = ({ children }) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this component?

@ohadlevy
Copy link
Member

@orrabin whats the status of the PR? thanks

@coveralls
Copy link

coveralls commented Dec 25, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 69.544% when pulling 989dc0b on orrabin:25600 into edc0a1c on theforeman:develop.

@orrabin
Copy link
Member Author

orrabin commented Dec 25, 2018 •
edited
Loading

@ohadlevy updated today resolving the comment from @amirfefer

@orrabin
Fixes #25600 - Migrate Icon to patternfly-react
989dc0b 
Remove Icon from foreman
Switch DocumentLinkContent to use patternfly-react Icon
@ohadlevy ohadlevy merged commit a91f168 into theforeman:develop Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldenraines waldenraines waldenraines left review comments

@amirfefer amirfefer amirfefer requested changes

@ohadlevy ohadlevy ohadlevy approved these changes

@sharvit sharvit sharvit approved these changes

Assignees
No one assigned
Labels
Needs testing UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@orrabin @theforeman-bot @sharvit @amirfefer @ohadlevy @coveralls @waldenraines