fixes #2142 add Smart Parameters and Smart Class Parameters to API v2 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domcleal, I don't see which test failed for 1.8.7 and Postgres |
|
@isratrade not sure, ignore it [test] |
| module V2 | ||
| class LookupKeysController < V2::BaseController | ||
| include Api::Version2 | ||
| include Api::TaxonomyScope |
There was a problem hiding this comment.
Yes, it's now removed and rebased.
|
@dmitri Dolguikh, re-based |
|
@witlessbird, rebased |
|
lgtm. |
|
Thanks @isratrade, I'm looking forward to lookup_values! Merged as 248cad8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API for overwriting values (or lookup_values) is not yet implemented. This PR is for lookup_keys only