Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25956 - update fog libvirt references #6447

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

jlsherrill
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

Issues: #25956

@jlsherrill
Copy link
Contributor Author

Should we try to support older versions of fog-libvirt? Is it okay to only support 0.6.0 and newer?

@jlsherrill
Copy link
Contributor Author

If we do want to support older versions, i opened: #6448 as an alternative pr. Feel free to close whichever one isn't needed.

@mmoll
Copy link
Contributor

mmoll commented Jan 31, 2019

I'd prefer this one here. Independently of this I'm going to open PRs for pinning the version for older branches...

Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @mmoll, let's keep the develop working with latest/greatest, and pin the versions in older branches, so that we don't end up with old code rotting here.

@iNecas iNecas merged commit f34b279 into theforeman:develop Feb 4, 2019
@iNecas
Copy link
Member

iNecas commented Feb 4, 2019

Thanks @jlsherrill

@mmoll
Copy link
Contributor

mmoll commented Feb 4, 2019

This will need an RPM update then...

@iNecas
Copy link
Member

iNecas commented Feb 4, 2019

Here we go theforeman/foreman-packaging#3431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants