Refs #26299 - fixes the bug in mailer #6651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #26299 |
ares
approved these changes
Apr 5, 2019
There was a problem hiding this comment.
Interesting, I haven't notice since the task stops with warning only. We should add notifications for scheduled reports or reports sent via email, so user is informed if something goes wrong. I know @iNecas is working on some generic solution for failed tasks, but this ends up with warning only.
Anyway, tested and fixes the problem. Thanks @ezr-ondrej, merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had introduced a bug in the last minute changes.
This is twice syntax error 😞