Fixes #26834 - local boot template setting can be lowercase #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #26834 |
timogoebel
approved these changes
May 21, 2019
|
One failure unrelated, bundler issue. [test foreman] Katello unrelated. |
|
merged, díky @lzap! |
Thanks guys, this fixed my issue with the ipxe default template overriding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Params are named local_boot_ipxe but local_boot_PXELinux. Let's make them all lowercase, but keep the old versions for backward compatibility.
Tests are present for normal case, I don't think it is necessary to copy
whole test just for this small thing, it's minor and small risk.