Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26756 - drop invalid values for scsi_controller_type (#6744) #6800

Merged
merged 1 commit into from
May 27, 2019
Merged

Fixes #26756 - drop invalid values for scsi_controller_type (#6744) #6800

merged 1 commit into from
May 27, 2019

Conversation

ezr-ondrej
Copy link
Member

Cherry pick for #6744

@theforeman-bot
Copy link
Member

Issues: #26756

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 72cc222 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@theforeman-bot theforeman-bot added Waiting on contributor Needs testing Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels May 26, 2019
@tbrisker
Copy link
Member

@ezr-ondrej can you please use git cherry-pick -x from the commit in develop branch?

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 5eff53c exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@ezr-ondrej
Copy link
Member Author

@tbrisker the commit message is too long due to the PR number 😢 should I do something about it, will be inconsistent with the original message if I do.

tbrisker
tbrisker approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, thanks!

@tbrisker tbrisker merged commit a2f897f into theforeman:1.22-stable May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing Stable branch PRs that are opened against a stable branch. Usually a cherry pick Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezr-ondrej @theforeman-bot @tbrisker