Fixes #27537 - Show tooltip for vm memory size #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #27537 |
|
this is fine but just a workaround for broken spinner field, I think @ezr-ondrej looked at the issue a while ago so he may have some lead on how to fix it properly |
|
Yeah, this will work, because different javascript is catching it, but it doesn't solve the core issue. |
ezr-ondrej
reviewed
Aug 7, 2019
app/helpers/form_helper.rb
Outdated
| @@ -220,7 +220,7 @@ def byte_size_f(f, attr, options = {}) | |||
| options[:label_help] = _("When specifying custom value, add 'MB' or 'GB' at the end. Field is not case sensitive and MB is default if unspecified.") | |||
| options[:help_block] ||= soft_limit_warning_block | |||
| options[:help_block] += f.hidden_field(attr, :class => "real-hidden-value", :id => nil) | |||
| options[:label_help_options] = { :rel => 'popover-modal' } | |||
| options[:label_help_options] = { :data => { :placement => 'right' } } | |||
There was a problem hiding this comment.
Maybe we can just delete it, to be consistent with other fields whatever we decide to use globaly? Or is there a reason to be always on the right?
There was a problem hiding this comment.
It's just that other tooltips in the form are on the right. But it is a default, so I deleted it as suggested.
ezr-ondrej
approved these changes
Aug 8, 2019
|
failures of travis just an fetch failure on one version, ignoring... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.