Fixes #27589 - add sequence reset task #6974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #27589 |
ekohl
reviewed
Aug 12, 2019
lib/tasks/sequence.rake
Outdated
| @@ -0,0 +1,18 @@ | |||
| # TRANSLATORS: do not translate | |||
| desc <<-END_DESC | |||
| Useful tasks for SQL sequences. | |||
There was a problem hiding this comment.
Suggested change
| Useful tasks for SQL sequences. | |
| Reset PostgreSQL sequences to their max values. Does nothing on other databases. |
There was a problem hiding this comment.
Well it's explained on the second line here, this is rather generic sentence for the whole namespace but I am okay with this. Rebased.
lzap
force-pushed
the
reset-sequence-27589
branch
from
e926c2b
to
32256a8
Compare
tbrisker
reviewed
Aug 15, 2019
|
Database restore perhaps? |
|
should it be under the |
lzap
force-pushed
the
reset-sequence-27589
branch
from
32256a8
to
90caf7d
Compare
|
Moved it to the |
|
Failure unrelated, this should be ready. |
tbrisker
reviewed
Sep 2, 2019
lzap
force-pushed
the
reset-sequence-27589
branch
2 times, most recently
from
0a756fc
to
94360c6
Compare
|
Rebased. |
tbrisker
reviewed
Sep 3, 2019
lzap
force-pushed
the
reset-sequence-27589
branch
from
94360c6
to
ae83485
Compare
tbrisker
approved these changes
Sep 3, 2019
|
Test failure unrelated. |
|
1.23 - 6e2ab45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MySQL migration we need a nice way to reset sequence generators. Looks like Rails does provide this.