Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #28031 - pin signet on Ruby 2.3 #7101

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Fixes #28031 - pin signet on Ruby 2.3 #7101

merged 1 commit into from
Oct 10, 2019

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Oct 10, 2019

No description provided.

@theforeman-bot
Copy link
Member

Issues: #28031

tbrisker
tbrisker approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmoll !

tbrisker
tbrisker approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't affect RPM packaging since we use scl'ed ruby. Thanks @mmoll!

@tbrisker tbrisker merged commit 8166863 into theforeman:develop Oct 10, 2019
@mmoll mmoll deleted the signet branch October 10, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
Needs testing Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmoll @theforeman-bot @tbrisker