Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28007 - Remove taxonomies from parameter params #7104

Closed

Conversation

ofedoren
Copy link
Member

After #6878 we cannot create/update (global) parameters for any resource (loc/org/hostgroup/etc).

I'm afraid this is not the best solution, so adding @tbrisker, @kgaikwad to the loop.

This fix doesn't permit location_id and organization_id which are set by default under parameter params.

If there is a better way to ensure that loc/org_id is not being set under parameter params, please point me :)

@theforeman-bot
Copy link
Member

Issues: #28007

@tbrisker
Copy link
Member

This should be properly fixed at https://github.com/theforeman/foreman/blob/develop/app/controllers/api/base_controller.rb#L245 imho, we need this parameter for org/loc params.

@tbrisker
Copy link
Member

Looks like this issue is a duplicate and there is already another attempt to fix it at GH-7091 - please collaborate with @jovandeginste to get a working solution. Closing this one for now.

@tbrisker tbrisker closed this Oct 11, 2019
@jovandeginste
Copy link
Contributor

jovandeginste commented Oct 15, 2019

@ofedoren I prefer your fix; @tbrisker can we close my PR in favor of this one?

Edit: I tried this PR in our environment, it seems to fix my issue too.

@ofedoren ofedoren deleted the bug-28007-param-creating branch July 12, 2022 13:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants