Fixes #28093 - Wrong host ownership in UserMailNotifications #7422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong list of hosts in "Configuration Management Summary Report" when view_host permission is used with filter "owner = current_user"
|
Issues: #28093 |
timogoebel
reviewed
Feb 7, 2020
Do it in User.as block so that the conext is restored after.
houndci-bot
reviewed
Feb 7, 2020
Place the Host.authorized search in a begin block so when it fails it does not brake sending emails for other users. Also, place it in an User.as block so it executes in the contex of the user being checked
houndci-bot
reviewed
Feb 7, 2020
Fix detected coding standard violations
houndci-bot
reviewed
Feb 10, 2020
tbrisker
suggested changes
Mar 12, 2020
| users.select { |user| Host.authorized_as(user, :view_hosts).find(host.id).present? } | ||
| users = users.select do |user| | ||
| User.as user do | ||
| Host.authorized_as(user, :view_hosts).find(host.id).present? |
There was a problem hiding this comment.
Suggested change
| Host.authorized_as(user, :view_hosts).find(host.id).present? | |
| Host.authorized(:view_hosts).find(host.id).present? |
| @@ -6,7 +6,9 @@ class HostMailer < ApplicationMailer | |||
| # sends out a summary email of hosts and their metrics (e.g. how many changes failures etc). | |||
| def summary(options = {}) | |||
| raise ::Foreman::Exception.new(N_("Must specify a valid user with email enabled")) unless (user = User.find(options[:user])) | |||
| hosts = Host::Managed.authorized_as(user, :view_hosts, Host) | |||
| hosts = User.as user do | |||
| Host::Managed.authorized_as(user, :view_hosts, Host) | |||
There was a problem hiding this comment.
Since you are in a user scope, you can use authorized instead of authorized_as here and below:
Suggested change
| Host::Managed.authorized_as(user, :view_hosts, Host) | |
| Host::Managed.authorized(:view_hosts) |
tbrisker
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Thanks @emildragu ! I'll merge this now and push another PR to improve on it.
|
for the record - #7543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong list of hosts in "Configuration Management Summary Report" when view_host permission
is used with filter "owner = current_user"