Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #29163 - Update Rubocop to 0.80 #7467

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Fixes #29163 - Update Rubocop to 0.80 #7467

merged 2 commits into from
Mar 8, 2020

Conversation

mmoll
Copy link
Contributor

@mmoll mmoll commented Feb 25, 2020

No description provided.

@theforeman-bot
Copy link
Member

Issues: #29163

ekohl
ekohl previously approved these changes Feb 25, 2020
View reviewed changes
@tbrisker tbrisker self-assigned this Feb 26, 2020
@mmoll
Copy link
Contributor Author

mmoll commented Feb 26, 2020

Katello PR: Katello/katello#8582

tbrisker
tbrisker approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmoll ! please post on discourse so plugin maintainers know they need to update their plugins as well.

@tbrisker tbrisker merged commit effd237 into theforeman:develop Mar 8, 2020
@mmoll mmoll deleted the rubocop_0_80 branch March 8, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

@ekohl ekohl ekohl left review comments

Assignees

@tbrisker tbrisker

Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmoll @theforeman-bot @ekohl @tbrisker