Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #29018 - Cherry pick to 1.24 - disabled buttons are still working #7470

Closed
wants to merge 1 commit into from
Closed

Fixes #29018 - Cherry pick to 1.24 - disabled buttons are still working #7470

wants to merge 1 commit into from

Conversation

Ron-Lavi
Copy link
Member

(cherry picked from commit 3bc2e63)

@theforeman-bot
Copy link
Member

Issues: #29018

@theforeman-bot theforeman-bot added Needs testing Not yet reviewed Legacy JS PRs making changes in the legacy Javascript stack Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Feb 26, 2020
@Ron-Lavi Ron-Lavi changed the title Fixes #29018 - disabled buttons are still working Fixes #29018 - Cherry pick to 1.24 - disabled buttons are still working Feb 26, 2020
@tbrisker tbrisker self-assigned this Feb 26, 2020
@tbrisker
Copy link
Member

tbrisker commented Mar 8, 2020

I think you cherry-picked from the wrong branch, the commit in develop is 3caf38a. In future when cherry-picking please do so for all supported stable branches where it makes sense (i.e. in this case to 2.0-stable as well).
Manually cherry-picked as 7074199.

@tbrisker tbrisker closed this Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tbrisker tbrisker

Labels
Legacy JS PRs making changes in the legacy Javascript stack Needs testing Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick
Projects
None yet
Milestone
No milestone
3 participants
@Ron-Lavi @theforeman-bot @tbrisker