Fixes #2712 - Handle Net::SSH::Disconnect gracefully #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +72,7 @@ def logger | |||
| def initiate_connection! | |||
| Timeout::timeout(360) do | |||
| begin | |||
| Timeout::timeout(8) do | |||
| Timeout::timeout(30) do | |||
There was a problem hiding this comment.
why 30? this would make every time you try to ssh to wait for 30 seconds? I think its better to try in shorter intervals?
There was a problem hiding this comment.
That's only the total timeout, accumulated over each failure. Given I can get 2-3 Econn::Refused followed by Net::SSH::Disconnect for 10-15s while it generates new Host keys, a total timeout of 8s is not enough.
|
Thanks @GregSutcliffe, merged as 0b5d270. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.