Fixes #28182 - fixing broken search bar in facts #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #28182 |
houndci-bot
reviewed
Apr 5, 2020
|
ekohl
reviewed
Apr 5, 2020
There was a problem hiding this comment.
I ran into this bug last Friday so I can confirm it's annoying. However, I wonder if a separate parameter really the correct way. Shouldn't it check if params[:search] is not blank? The search may also be a complex expression. Some cases I can think of that might fail, but not sure if they will:
name = myfact or name = my_other_factshould be(name = myfact or name = my_other_fact) and ...name = myfact and fqdn = host.example.comwill result inname = myfact and fqdn = host.example.com and fqdn = host.example.com(note the double space)
It would be good to have test cases for this.
ezr-ondrej
requested changes
Apr 15, 2020
houndci-bot
reviewed
May 10, 2020
|
Thanks @ezr-ondrej , @ekohl ! I've added also a test |
ekohl
requested changes
May 11, 2020
Comment on lines
26
to
28
| def has_search_param? | ||
| params[:search].blank? | ||
| end |
There was a problem hiding this comment.
This appears unused and also reversed the logic.
tbrisker
suggested changes
May 11, 2020
ekohl
approved these changes
May 13, 2020
|
2.1 - 84d0f49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Host -> Facts page the search bar contains
host = $fqdn, and after cleaning it up and search for another query this happens:it should add a separator " and ":
