Fixes #29498 - improve pending_migrations check #7574
Conversation
|
Issues: #29498 |
This comment has been minimized.
This comment has been minimized.
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
ezr-ondrej
force-pushed
the
29491
branch
2 times, most recently
from
9e80029
to
9256785
Compare
ezr-ondrej
force-pushed
the
29491
branch
2 times, most recently
from
f8de81e
to
68042bc
Compare
| rescue NameError => e | ||
| Foreman::Logging.exception("Failed to register plugin #{name}", e) | ||
| nil | ||
| Dir.glob(plugin.engine.root + 'db/seeds.d/*.rb') if plugin.engine |
There was a problem hiding this comment.
Would it make sense to add a helper in the plugin itself to return this glob? Like plugin.seeds
There was a problem hiding this comment.
unsure about this one 🤔 we don't need it anywhere else, and there is the same path for foreman few lines above this one. I don't have preference tho, I can abstract it to the plugin if it makes more sense :)
There was a problem hiding this comment.
I'm fine with this the way it is
|
needs rebase |
|
[test foreman] |
| end | ||
|
|
||
| def migrations_paths | ||
| engine.paths['db/migrate'].existent |
There was a problem hiding this comment.
The test failures seem to be related to the fact that engine can be nil, or at least in tests
There was a problem hiding this comment.
Yeah, then skipping the check is a valid option, as without engine, the plugin has no migrations. Done that, by early return.
|
🍏 |
|
Thank you @ezr-ondrej and everyone involved in the discussion! |
|
|
||
| pending_migrations = ActiveRecord::Base.connection.migration_context.needs_migration? | ||
| @pending_migrations = ActiveRecord::MigrationContext.new(migrations_paths, ActiveRecord::SchemaMigration).needs_migration? |
There was a problem hiding this comment.
It looks like this caused https://projects.theforeman.org/issues/30821. If a plugin has no migrations but uses permissions, this fails in packaging. I think it should still take the main DB into account, as well as plugins.
Check plugins migrations instead of core ones (or should we check both?).
More info in the ticket.