Fixes #29402 - Add missing gov region for EC2 #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #29402 |
apuntamb
force-pushed
the
add-us-gov-east-1
branch
from
780fa67
to
2a8e60a
Compare
houndci-bot
reviewed
May 13, 2020
shiramax
suggested changes
May 13, 2020
apuntamb
force-pushed
the
add-us-gov-east-1
branch
from
2a8e60a
to
a0d3f8c
Compare
shiramax
previously approved these changes
May 14, 2020
apuntamb
force-pushed
the
add-us-gov-east-1
branch
from
a0d3f8c
to
730639e
Compare
shiramax
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of a new gov region
us-gov-east-1in AWS, Foreman EC2 doesn't support it due to the hardcodedGOV_CLOUD_REGIONin the model.If the API calls work for gov cloud as well, for example here:
[#describe_regions](https://github.com/theforeman/foreman/blob/develop/app/models/compute_resources/foreman/model/ec2.rb#L82)then we can remove setting theself.urlexplicitly with hardcoded region.Still considering it WIP.