Fixes #30601 - replace mount_react_component in toasts #7943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #30601 |
Ron-Lavi
reviewed
Aug 31, 2020
| @@ -474,7 +474,7 @@ def user_set?(field) | |||
| def notifications | |||
| content_tag :div, id: 'toast-notifications-container', | |||
| 'data-notifications': toast_notifications_data.to_json.html_safe do | |||
| mount_react_component('ToastNotifications', '#toast-notifications-container') | |||
| react_component('ToastNotifications') | |||
There was a problem hiding this comment.
Can you also remove the content_tag from line 475?
There was a problem hiding this comment.
I can't because the notification load from <div id='toast-notifications-container' data-notifications='some_notifications'> and then deleted by removing the data-notifications attribute from the div
Ron-Lavi
approved these changes
Sep 1, 2020
amirfefer
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't want to make this a toast refactor PR so I kept the div for the J-Query to add toasts
replaces mount_react_component with react_component in ToastNotifications