Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #30839 - accept Arrays of nested compute attributes #8006

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

ezr-ondrej
Copy link
Member

API should be able to handle interfaces_attributes: [{attrs1},{attrs2}],
Until now it only handled hashes with numbered keys.

@theforeman-bot
Copy link
Member

Issues: #30839

API should be able to handle interfaces_attributes: [{attrs1},{attrs2}],
Until now it only handled hashes with numbered keys.
@ezr-ondrej
Copy link
Member Author

[test foreman]

Copy link
Contributor

@shiramax shiramax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks @ezr-ondrej

@shiramax shiramax merged commit d00fc37 into theforeman:develop Oct 15, 2020
@ezr-ondrej ezr-ondrej deleted the array_compute_attributes branch October 15, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants