fixes #2693 - don't cause handle_ca error when no Puppet CA associated with host #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Untested, but looks sane to me. Over to you Jenkins ;) |
| respond_to?(:initialize_puppetca,true) && initialize_puppetca && delCertificate && setAutosign | ||
| end | ||
| return true unless puppetca? | ||
| respond_to?(:initialize_puppetca,true) && initialize_puppetca && delCertificate && setAutosign |
There was a problem hiding this comment.
what am I missing? that it returned false before?
There was a problem hiding this comment.
it returned nil before, which caused the controller to think it'd failed. You wrote this patch :)
There was a problem hiding this comment.
… associated with host
|
@ohadlevy ignore the test failures, they're due to lack of disk space on slaves. I updated the commit only to remove some trailing whitespace from the patch. |
|
ping @ohadlevy |
|
merged as f09d61d - thanks! |
cfouant
pushed a commit
to cfouant/foreman
that referenced
this pull request
Dec 18, 2018
instead of having separate playbooks for each version of the pipeline, have one playbook and load version specific data from vars_files. also adds vars_files statements where no version specific data is present today, to allow overriding in future. see [1] for details. [1] https://docs.ansible.com/ansible/2.7/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable Fixes: GH-theforeman#806
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.