-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #2693 - don't cause handle_ca error when no Puppet CA associated with host #806
Conversation
Untested, but looks sane to me. Over to you Jenkins ;) |
respond_to?(:initialize_puppetca,true) && initialize_puppetca && delCertificate && setAutosign | ||
end | ||
return true unless puppetca? | ||
respond_to?(:initialize_puppetca,true) && initialize_puppetca && delCertificate && setAutosign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what am I missing? that it returned false before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it returned nil before, which caused the controller to think it'd failed. You wrote this patch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case 👍
… associated with host
@ohadlevy ignore the test failures, they're due to lack of disk space on slaves. I updated the commit only to remove some trailing whitespace from the patch. |
ping @ohadlevy |
merged as f09d61d - thanks! |
instead of having separate playbooks for each version of the pipeline, have one playbook and load version specific data from vars_files. also adds vars_files statements where no version specific data is present today, to allow overriding in future. see [1] for details. [1] https://docs.ansible.com/ansible/2.7/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable Fixes: GH-theforeman#806
No description provided.