Fixes #32029 - test coverage for taxed_and_untaxed #8370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add scoping for current search tests to divide those and newly added tax and permission tests.
|
Issues: #32029 |
ezr-ondrej
changed the title
ezr-ondrej
force-pushed
the
audit_tests
branch
3 times, most recently
from
bcb7204
to
afa0135
Compare
ezr-ondrej
changed the title
|
One of the unit tests failed, and integration tests stalled so there is probably something wrong here |
It seems to be my simple code improvement fault. I've removed it, it didn't belong here. We are green, but testing the bugged version. (current subtaxonomy allows to see parent records). |
tbrisker
approved these changes
Mar 9, 2021
|
I've created two, because two is more than one! https://projects.theforeman.org/issues/32053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test coverage for
taxed_and_untaxedscope so we have better confidency over its refactorings.Note I've splitted to two commits, so the additions are more readable.
So for easier review just take a look at the last commit.