Fixes #31361 - Mark strings translatable for infrastructure page #8420
Conversation
|
Issues: #31361 |
| @@ -1,9 +1,9 @@ | |||
| <% origin = @data.settings[:origin] %> | |||
| <h4 class="header"> | |||
| <% if origin %> | |||
| <%= N_('Run Distribution Chart for %s') % origin %> | |||
| <%= _('Run Distribution Chart for %s') % origin %> | |||
There was a problem hiding this comment.
This is going to be for my understanding because I couldn't find it (_ and N_ are hard search terms): what's the difference between N_() and _()?
There was a problem hiding this comment.
Hello,
The wiki page says To mark something for translation (but not translate) use N_("String"). As per my understanding we should only skip translations on product names, specific technical terms etc. I also checked if we have any guidelines on which strings should not be translated but didn't get anything specific. Accordingly this should be translated and should not be skipped.
https://projects.theforeman.org/projects/foreman/wiki/Translating
There was a problem hiding this comment.
N_() is used to mark strings that should be translated (i.e. extracted to the translation team), but can't be translated at runtime due to no locale present when they are accessed (think for example inside models). Generally, strings inside controllers, helpers, and views should use _(), while strings elsewhere (for the most part) should use N_().
No description provided.