Fixes #32238 - Bind systemd socket to IPv6 (CP 2.4) #8433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default foreman.socket binds to IPv4 only. This was done to make matching it in Puma easier, but it's not really what should be done in 2021 where everything should be dual stack by default. In aecc318 the need for this matching in Puma was removed which makes it much more flexible. The default should be updated. Note that the installer currently always overrides it so it's not really a difference for most, but I want to modify the installer to rely on the default. (cherry picked from commit 3347fa4)
|
Issues: #32238 |
ezr-ondrej
changed the title
ekohl
approved these changes
Apr 7, 2021
ekohl
added
the
Stable branch
|
when merging to stable branch please remember to update the "fixed in" field in redmine :) |
|
Hmm, I may have to revisit automating that part for merged PRs to stable branches :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default foreman.socket binds to IPv4 only. This was done to make
matching it in Puma easier, but it's not really what should be done in
2021 where everything should be dual stack by default.
In aecc318 the need for this matching
in Puma was removed which makes it much more flexible. The default
should be updated.
Note that the installer currently always overrides it so it's not really
a difference for most, but I want to modify the installer to rely on the
default.
(cherry picked from commit 3347fa4)