-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #31307 - Improve compute network error messages #8520
Conversation
Issues: #31307 |
For testing:
|
I don't think that the foreman test issue in 2.7 is related to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good, @timogoebel ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbernhard: I'm good as well, please make sure the checks are green or else we can't merge.
On merge we should fix up the commit message to match what I did to the title of this PR. It's just a bit more descriptive. |
Previously, if the connection to the compute resource fails, the following error message was shown. Failed to find compute attributes, please check if VM 'xyz' was deleted. Users are completely confused. With the following change nice error messages are shown: Reject: Receiving vm data for host 'xyz.local' from used compute resource 'VMware' failed: 'Connection to compute resource refused'. Unreachable: Receiving vm data for host 'xyz.local' from used compute resource 'VMware' failed: 'Compute resource destination unreachable'. Timeout: Receiving vm data for host 'xyz.local' from used compute resource 'VMware' failed: 'Connection to compute resource timed out'.
done. Thanks @ekohl |
[test upgrade] |
@ezr-ondrej: Are you good as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezr-ondrej: Are you good as well?
Yeah, I just didn't see you've already reviewed :)
Thanks, everyone! :)
I need to gain some karma points today. :) |
Cherry pick in GH-8616 |
Previously, if the connection to the compute resource fails, the
following error message was shown.
Failed to find compute attributes, please check if VM 'xyz' was deleted.
Users are completely confused. With the following change nice error
messages are shown:
Reject:
Receiving vm data for host 'xyz.local' from used compute resource 'VMware' failed: 'Connection to compute resource refused'.
Unreachable:
Receiving vm data for host 'xyz.local' from used compute resource 'VMware' failed: 'Compute resource destination unreachable'.
Timeout:
Receiving vm data for host 'xyz.local' from used compute resource 'VMware' failed: 'Connection to compute resource timed out'.