Fixes #32782 - Add types and queries for Lookup Values #8585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #32782 |
ezr-ondrej
reviewed
Jun 25, 2021
There was a problem hiding this comment.
This make sense and I'm ok with that as it is definitelly a way forward, though I'm not sure this include inherited values. Or does it?
Do we even want that?
Can we add such values in test (ie on OS for the HG) and explicitly expect them to be there or not, so we know in the future how it was supposed to behave?
xprazak2
force-pushed
the
lookup-values-gql
branch
from
f824c6f
to
89cea7a
Compare
|
I added a test case where matcher is a value for child hostgroup, but I do not think inheritance is relevant here. Query for single record fetches lookup value by id and query for collection fetches a collection and ou can always use search to filter the results. |
ezr-ondrej
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.