Use a persistent websockify process #8698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #22801 |
While WsProxy already encrypted the connection, the UI was hardcoded to ws://. With this patch it respects the websockets_encrypt setting and uses wss:// if needed.
ekohl
force-pushed
the
persistent-websockets-proxy
branch
from
a33c261
to
8ded6f6
Compare
|
Thank you for your contribution, @ekohl! This PR has been inactive for 3 months, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough implementation of https://community.theforeman.org/t/consolidating-the-console/11215.
Includes #8515 & #8697. Right now this is really nowhere near ready to merge. TODO: