-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #33215 - Registration - link to documentation #8704
Conversation
Issues: #33215 |
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
20bfef1
to
dbcd968
Compare
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
dbcd968
to
a5ea85d
Compare
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
a5ea85d
to
e5ebe0d
Compare
|
||
export const docUrl = (foremanVersion) => { | ||
const rootUrl = `https://docs.theforeman.org/${foremanVersion}/` | ||
const section = 'Managing_Hosts/index-foreman-el.html#registering-a-host_managing-hosts' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is changing. Is this still safe to cherry pick to 2.5 or would it be a slightly different cherry pick?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this can't be cherry picked to 2.5. But it is not a problem, downstream branch is not rebased anymore over the Foreman 2.5-stable, so there is no need for cherry-pick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But for users of 2.5 it is weird because that documentation link is broken. So I'd argue it still needs a cherry pick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 2.5 doc link is the old one:
https://docs.theforeman.org/2.5/Managing_Hosts/index-foreman-el.html#registering-a-host-to-project-using-the-global-registration-template_managing-hosts
so no need to cherry-pick it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stejskalleos, We still need to use the links controller in 2.5 for downstream branding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShimShtein yop, for downstream 2.5 branch we will cherry-pick it
Link to documentation should not be hardcoded in the React component but should go through LinksController
e5ebe0d
to
9e641c4
Compare
Looks good, merging. @stejskalleos , don't forget to cherry-pick the correct link to 2.5 |
@ShimShtein Thanks for merge, luckily there is no need to cherry-pick it to 2.5, see my #8704 (comment) |
Link to documentation should not be hardcoded
in the React component but should go through
LinksController