Fixes #33215 - Registration - link to documentation #8704
Conversation
|
Issues: #33215 |
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
stejskalleos
force-pushed
the
ls/doc_reg
branch
from
20bfef1
to
dbcd968
Compare
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
stejskalleos
force-pushed
the
ls/doc_reg
branch
from
dbcd968
to
a5ea85d
Compare
...pp/routes/RegistrationCommands/RegistrationCommandsPage/RegistrationCommandsPageConstants.js
Outdated
Show resolved
Hide resolved
stejskalleos
force-pushed
the
ls/doc_reg
branch
from
a5ea85d
to
e5ebe0d
Compare
|
|
||
| export const docUrl = (foremanVersion) => { | ||
| const rootUrl = `https://docs.theforeman.org/${foremanVersion}/` | ||
| const section = 'Managing_Hosts/index-foreman-el.html#registering-a-host_managing-hosts' |
There was a problem hiding this comment.
The link is changing. Is this still safe to cherry pick to 2.5 or would it be a slightly different cherry pick?
There was a problem hiding this comment.
You are right, this can't be cherry picked to 2.5. But it is not a problem, downstream branch is not rebased anymore over the Foreman 2.5-stable, so there is no need for cherry-pick.
There was a problem hiding this comment.
But for users of 2.5 it is weird because that documentation link is broken. So I'd argue it still needs a cherry pick.
There was a problem hiding this comment.
For 2.5 doc link is the old one:
https://docs.theforeman.org/2.5/Managing_Hosts/index-foreman-el.html#registering-a-host-to-project-using-the-global-registration-template_managing-hosts
so no need to cherry-pick it
There was a problem hiding this comment.
@stejskalleos, We still need to use the links controller in 2.5 for downstream branding
There was a problem hiding this comment.
@ShimShtein yop, for downstream 2.5 branch we will cherry-pick it
Link to documentation should not be hardcoded in the React component but should go through LinksController
stejskalleos
force-pushed
the
ls/doc_reg
branch
from
e5ebe0d
to
9e641c4
Compare
|
Looks good, merging. @stejskalleos , don't forget to cherry-pick the correct link to 2.5 |
|
@ShimShtein Thanks for merge, luckily there is no need to cherry-pick it to 2.5, see my #8704 (comment) |
Link to documentation should not be hardcoded
in the React component but should go through
LinksController