Fixes #33660 - ignore dynflow tables for dump #8822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #33660 |
adamruzicka
previously approved these changes
Oct 13, 2021
|
Even though it seems to work on my machine, test failures seem related |
|
@lzap ping |
lzap
force-pushed
the
dynflow-dump-exclude-33660
branch
from
8f446f7
to
140a224
Compare
|
Rebased. |
adamruzicka
reviewed
Nov 9, 2021
Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
lzap
force-pushed
the
dynflow-dump-exclude-33660
branch
from
140a224
to
7e588ce
Compare
|
Rebased! |
|
Seems to work well, waiting for the tests to pass |
adamruzicka
approved these changes
Mar 3, 2022
|
Thank you @lzap ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby schema dump contains dynflow tables again, which is causing issues with foreign keys with multi-column PKs.
Regression introduced in #8660