Load Menu::Loader in 'befor_init' #8938
Conversation
|
Issues: #33884 |
|
Can we have a subtask for the RM 33886? Or use Refs #33886, but this is not the fix for the RM it is referencing :) |
stejskalleos
force-pushed
the
ls/init_foreman_menu
branch
from
a492fdf
to
e41cc30
Compare
|
Yop, correct RM: https://projects.theforeman.org/issues/33964 |
config/initializers/foreman.rb
Outdated
| Foreman::Plugin.initialize_default_registries | ||
| Foreman::Plugin.medium_providers_registry.register MediumProviders::Default | ||
|
|
||
| Rails.application.config.to_prepare do | ||
| # load topbar | ||
| Menu::Loader.load |
There was a problem hiding this comment.
The menu disappears for me with this change.
Though it's wrong even conceptually I believe, Menu::Manager is in registries folder, which is autoload_once (never reloaded). This is probably wrong and we should reload menu on code reload, but we do not, so it would load the menu items multiple times.
So IMHO, this is a candidate for before_initialize, because it has already initialized the Rails.autoloaders.once, which holds the Menu constant. Check the bootstrap.rb
There was a problem hiding this comment.
The menu disappears for me with this change.
Really? Because it works for me fine (on vanilla foreman, no plugins)
There was a problem hiding this comment.
Though it's wrong even conceptually I believe, Menu::Manager is in registries folder, which is autoload_once (never reloaded). This is probably wrong and we should reload menu on code reload, but we do not, so it would load the menu items multiple times.
Maybe we should move it to services and reload it on every change
There was a problem hiding this comment.
Yeah, when you add plugins into the mix it stop working, because the root menus got initialized from plugins too soon and Foreman won't reinitialize them properly.
Maybe we should move it to services and reload it on every change
I believe we should, there is no real reason to initialize it soon, but that's a bit of a challange to do it correctly as there might be 🐉s :)
If you're up for implementing it I'm all for it, but putting it into before_initialize is acceptable workaround for me :)
There was a problem hiding this comment.
For now I put Menu::Loader.load to before_initialize, for follow up refactoring I created https://projects.theforeman.org/issues/33975 so if there will be time I'll look into it
|
|
||
| # clear our users topbar cache | ||
| # The users table may not be exist during initial migration of the database | ||
| TopbarSweeper.expire_cache_all_users if (User.table_exists? rescue false) |
There was a problem hiding this comment.
Probably won't hurt to delete the cache on every code reload 🤷
So I guess 👍 on this
stejskalleos
force-pushed
the
ls/init_foreman_menu
branch
from
e41cc30
to
05daca8
Compare
stejskalleos
changed the title
No description provided.