Autoload ProxyAPI files from /app/services #8993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #34138 |
stejskalleos
force-pushed
the
ls/proxy_api
branch
from
6b0a21f
to
82cf965
Compare
stejskalleos
changed the title
ezr-ondrej
reviewed
Dec 13, 2021
There was a problem hiding this comment.
Did you change the boot_server just because you've seen it?
I know it is hard to resist this, but might be better unless we have incentive to do so.
Don't get me wrong, I like it, I don't agree with the initial reason for it (the one I suspect), it is just it might break stuff unnecessarily :)
stejskalleos
force-pushed
the
ls/proxy_api
branch
from
82cf965
to
5ebeb4d
Compare
stejskalleos
changed the title
I was trying to make rubocop happy :D But if I think about it it would be safer to just update Anyway PR rebased & updated, ready for review |
stejskalleos
force-pushed
the
ls/proxy_api
branch
from
5ebeb4d
to
8374ef2
Compare
ezr-ondrej
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.