Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #34349 - improve api/settings#index coverage #9070

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Fixes #34349 - improve api/settings#index coverage #9070

merged 1 commit into from
Feb 1, 2022

Conversation

ezr-ondrej
Copy link
Member

No description provided.

@theforeman-bot
Copy link
Member

Issues: #34349

@ezr-ondrej ezr-ondrej mentioned this pull request Jan 30, 2022
Merged
@evgeni
Copy link
Member

evgeni commented Jan 31, 2022 •
edited
Loading 

Failure:
test_0001_should get index(Minitest::Result) [/home/jenkins/workspace/test_develop_pr_core/database/postgresql/ruby/2.5/slave/fast/test/controllers/api/v2/settings_controller_test.rb:15]:
Expected: 112
  Actual: 20

🤷‍♀️

something, something, paging?

@ezr-ondrej ezr-ondrej force-pushed the setting_test_coverage branch 2 times, most recently from 70b535e to f8556b4 Compare January 31, 2022 10:05
@ezr-ondrej
Copy link
Member Author

something, something, paging?

Yeah pagination not set properly.

evgeni
evgeni previously approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind rebasing this once, so we see it green after the fun we had with #9062? :D

@ezr-ondrej
Copy link
Member Author

sure :) let's get a little bit more confidence, that never hurts :)

@evgeni
Copy link
Member

evgeni commented Feb 1, 2022

[test katello]

This seems unrelated

@ezr-ondrej
Copy link
Member Author

[test katello]
I mean it can't be related

@ezr-ondrej
Copy link
Member Author

🍏

@evgeni evgeni merged commit 76650c9 into theforeman:develop Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezr-ondrej @theforeman-bot @evgeni