Update pkg_manager.erb to include support/detection for AmazonLinux 2 and AmazonLinux 2022 #9469
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
| @@ -31,6 +31,10 @@ elif [ -f /etc/redhat-release ] ; then | |||
| else | |||
| PKG_MANAGER='yum' | |||
| fi | |||
| elif [ -f /etc/amazon-linux-release ]; then | |||
| PKG_MANAGER='dnf' | |||
| elif [ -f /etc/system-release ]; then | |||
There was a problem hiding this comment.
Out of interest: which other systems use /etc/system-release? And we already source /etc/os-release if it's present. Can't we rely on those variables?
There was a problem hiding this comment.
/etc/os-release is available, but the snippet doesn't recognize yum in Amazon Linux 2.
The current RHEL clones support /etc/system-release (alma,rocky,amzn). Fedora and RHEL obviously but those already have explicit support/detection.
I found the reference from this post on Redhat, Proper way to extract Product, Release, Update, etc which discusses OS detection
3) System Release, vendor string: /etc/system-release (also via symlink, or legacy, /etc/fedora-release, /etc/redhat-release)
The response links to a sysconfcollect module that identifies some 50+ distros near the bottom of the page. I didnt check any of them because I don't use them, though I don't expect support for them in Foreman/Katello, as I don't imagine them seeing much use (if any) in Foreman installations.
There was a problem hiding this comment.
If we detect /etc/system-release can we use dnf instead of the yum?
Tested on Rocky & Alma and they both have dnf.
There was a problem hiding this comment.
Amazon Linux 2 still has yum since it's EL7 based. Amazon Linux 2022 is based on Fedora so it has dnf.
| @@ -31,6 +31,10 @@ elif [ -f /etc/redhat-release ] ; then | |||
| else | |||
| PKG_MANAGER='yum' | |||
| fi | |||
| elif [ -f /etc/amazon-linux-release ]; then | |||
| PKG_MANAGER='dnf' | |||
| elif [ -f /etc/system-release ]; then | |||
There was a problem hiding this comment.
If we detect /etc/system-release can we use dnf instead of the yum?
Tested on Rocky & Alma and they both have dnf.
imphocused
changed the title
|
@ekohl Changes LGTM, do you have any other comments? |
|
It still needs a Redmine issue and the commit should refer to it. Otherwise we can't merge it (our changelog generation relies on it). Other than that I'd be happy to accept it. |
There was a problem hiding this comment.
@imphocused I see that you changed the title in github but the commit message is still same: Update pkg_manager.erb
Commit message should be in format Fixes #35670 - Description of changes, where the number is id of the issue in our tracker system.
I created the #35670 issue for you, so please just update the message, for example like this: Fixes #35670 - pkg_manager.erb - support AmazonLinux 2 & 2022
This provides detection for AmazonLinux 2022 (dnf) and fallback support for Amazon Linux 2 (yum), as well as other RHEL'ish clones
|
I've updated and pushed the change, sorry for the delay. |
|
LGTM from my side, @ekohl any other comments? |
|
@imphocused any updates? Updating comment is last thing before we can merge |
…g individual distros
theforeman-bot
added
Needs re-review
Waiting on contributor
and removed
Waiting on contributor
labels
|
@ekohl any other comments? There are two commits now but I'll squash them before the merge |
This provides detection for AmazonLinux 2022 (dnf) and fallback 'yum' support for Amazon Linux 2, as well as other RHEL'ish clones which use /etc/system-release.