Fixes #36126 - handle install-disk in Preseed provisioning template

[olifre]

No description provided.

[theforeman-bot]

Can one of the admins verify this patch?

[theforeman-bot]

Can one of the admins verify this patch?

[theforeman-bot]

Can one of the admins verify this patch?

[theforeman-bot]

Issues: #36126

[sbernhard]

The install-disk parameter is used here (partition table):

foreman/app/views/unattended/partition_tables_templates/preseed_default.erb

Line 19 in 9d36142

d-i grub-installer/bootdev string <%= host_param('install-disk') %>

foreman/app/views/unattended/partition_tables_templates/preseed_default_lvm.erb

Line 20 in 3347fa4

<% if host_param('install-disk') -%>

can you please clarify if this is really required in the provisioning template?

[olifre]

@sbernhard Wow, I completely missed that — I will run further tests, to confirm that it is really not needed anymore when combining install-disk with an expert-recipe and come back to you, likely next week. Thanks for the pointer to the other location(s)!

[olifre]

I cross--checked and you are fully correct, the currently used partitioning template is completely sufficient. The need for this addition was caused by an outdated Preseed Partitioning template on our end, which did not yet have this feature included.
So let's close this PR (will also close the issue), sorry for the noise and thans for checking so carefully!