Fixes #36723 - Remove Fedora/Red Hat Atomic related code #9823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36723 |
ekohl
commented
Sep 20, 2023
| @@ -146,8 +143,6 @@ def get_rhsm_mac(interface) | |||
| end | |||
|
|
|||
| def distribution_to_puppet_os(name) | |||
| return REDHAT_ATOMIC_HOST_OS if name == REDHAT_ATOMIC_HOST_DISTRO_NAME | |||
|
|
|||
| name = name.downcase | |||
There was a problem hiding this comment.
I noticed this block could be cleaner using a case statement: #9838
As far as I can see this has been EOL for a few years now. Red Hat Atomic went EOL in 2021.
ekohl
force-pushed
the
36723-drop-atomic
branch
from
f767f7c
to
d833ff7
Compare
|
Thanks @ekohl |
|
Release note: theforeman/foreman-documentation#2486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can see this has been EOL for a few years now. Red Hat Atomic went EOL in 2021.