Fixes #36747 - create new snippet for subscription-manager setup

[nofaralfasi]

This snippet replaces the use of the katello-ca-consumer RPM for host registration. It incorporates the necessary code from the Global Registration template to streamline subscription-manager configuration during provisioning.

[ekohl]

Just thinking out loud: is there a way to reset these to default values so we don't need to track these values?

[nofaralfasi]

What do you mean by 'reset to default'? From what I know, the default is empty values.
And where else will we use these vars, that we wouldn't need to track them?

[stejskalleos]

The registration process doesn't work for me, see:

curl -sS  'http://centos8-katello-devel-stable.example.com/register?activation_keys=default&location_id=2&organization_id=1&update_packages=false' -H 'Authorization: Bearer  <token>'

returns: 
echo "ERROR: standard_error";
echo "ERF42-7327 [Foreman::Exception]: The snippet 'subscription_manager_setup' threw an error: wrong number of arguments (given 2, expected 1)";
exit 1

[stejskalleos]

Found the cause of the error: You need to pass the @rhsm_url to the snippet, something like this:

<%= snippet("subscription_manager_setup", variables: {existing_machine: true, subman_url: @rhsm_url }).strip %>

Dont pass it as rhsm_url: @rhsm_url, that won't work

[nofaralfasi]

Found the cause of the error: You need to pass the @rhsm_url to the snippet, something like this:

<%= snippet("subscription_manager_setup", variables: {existing_machine: true, subman_url: @rhsm_url }).strip %>

Dont pass it as rhsm_url: @rhsm_url, that won't work

Actually, that didn't work for me.
I found that the issue was with the use of the '&' operator in the subscription_manager_setup snippet, as follows:

if plugin_present?('katello')
  server_hostname = @rhsm_url&.host
  server_port = @rhsm_url&.port
  server_prefix = @rhsm_url&.path

[stejskalleos]

I found that the issue was with the use of the '&' operator

Oh yeah, looks like it's not allowed in the safe mode.

[ekohl]

Oh yeah, looks like it's not allowed in the safe mode.

I opened theforeman/safemode#46 almost a year ago.

[stejskalleos]

Should be this part of the if registration_method == 'provisioning' && plugin_present?('katello') block?

yggdrasild is used for REX pull provider, I guess people can use it without Katello and also set it up during the registration, not just provisioning.

@adamruzicka just want to confirm, can you use pull provider without Katello?

[adamruzicka]

You can use it without katello as long as you bring your own certs and set it up yourself, although I'm not sure if anyone does that. To be strictly correct, the restart should be outside the block.

[stejskalleos]

Few comments otherwise LGTM,
registration works as expected, and provisioning as well, I tried RHEL 8 & 9 without katello and hosts were successfully provisioned.

QAs will test provisioning with Katello.

[Lennonka]

Left you a couple of suggestions from the documentation perspective. (You don't have to incorporate all of them, unless you think they would be an improvement to the code.)

[nofaralfasi]

@stejskalleos should we check if the machine is RHEL compatible?
For example, here we are calling the redhat_register snipped without verifying the machine's RHEL compatibility.

[stejskalleos]

No need, kickstart is specifically for RHEL, if someone is going to use the snippet somewhere else, I expect that the person knows what is doing.

[shubhamsg199]

@stejskalleos @nofaralfasi I've tested this PR , It's not working as expected.
After the installation of the packages, it's not going to the registration section, It directly reboots and gives us the console. I also don't see the install.post.log file created to verify.

[nofaralfasi]

@shubhamsg199: I have resolved the issue, and it should now function as expected.

[shubhamsg199]

@shubhamsg199: I have resolved the issue, and it should now function as expected.

@nofaralfasi I will test this and update

[shubhamsg199]

@nofaralfasi Things are working as expected now.
One thing to note is the subscription_manager_setup snippet which is rendered has unnecessary contents in the kickstart default template, which I think should not be present there

[nofaralfasi]

@stejskalleos can we skip this line, since we are checking if PKG_MANAGER variable is set in the new snippet lines 13-14?

[stejskalleos]

What if someone will use the snippet only in their templates? Then it won't work ...

[nofaralfasi]

It should work, because we are checking it in the beginning of the new snippet - lines 13-14.

[stejskalleos]

Oh, I see. Well, it needs to be rendered at least once, before the variable is used, right ... if that is what's happening, then it's fine and it can be removed

[Lennonka]

LGTM docs-wise. Ping me if you need another review.

[stejskalleos]

🍏 LGTM,

Code looks sane, QAs confirmed functionality, so let's get this in!

[stejskalleos]

Thanks @nofaralfasi @shubhamsg199 and others!