Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36948 - Nav Search doesnt show ansible roles #9929

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

MariaAga
Copy link
Member

When there is a menu item with a duplicate name, the search will only show one item.
For example: administer > roles and ansible > roles.
Changes the object that had {title: {...data}} to be an array [{title, ...data}] so duplicates will not be overridden.
added a test to make sure duplicates are not ignored.

Copy link
Contributor

@kmalyjur kmalyjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga, love this feature even more now :)

Sorry for not noticing that few entries were missing before :/ I'm afraid we will need to CP this into 3.9.

@ofedoren ofedoren merged commit 4cee33a into theforeman:develop Nov 29, 2023
19 checks passed
@MariaAga
Copy link
Member Author

MariaAga commented Dec 4, 2023

@ofedoren Thanks! CP here: #9944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants