Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36949 - Clear nav search doesn't clear results #9930

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fixes #36949 - Clear nav search doesn't clear results #9930

merged 1 commit into from
Dec 4, 2023

Conversation

MariaAga
Copy link
Member

Blocked by #9929

@github-actions github-actions bot added the UI label Nov 27, 2023
@MariaAga MariaAga marked this pull request as ready for review November 30, 2023 09:25
@ofedoren
Copy link
Member

ofedoren commented Dec 1, 2023

Thanks, @MariaAga, the clear X works as expected now, but there is a small issue though. If a user clears the input "manually", the old suggestions are still there. Could you fix that as well? Apart from that LGTM and GTG :)

The problem is shown at the end of the gif:
Peek 2023-12-01 17-07.webm

@MariaAga
Copy link
Member Author

MariaAga commented Dec 1, 2023

@ofedoren Thanks! should be fixed now

ofedoren
ofedoren approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga, works as expected now :)

@ofedoren ofedoren merged commit 146826f into theforeman:develop Dec 4, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
2 participants
@MariaAga @ofedoren