-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #34152 - add 'assign roles' button to empty state #494
Conversation
history={history} | ||
hostGlobalId={hostGlobalId} | ||
emptyStateProps={{ | ||
title: __('No Ansible roles assigned'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshot at https://community.theforeman.org/t/foreman-3-0-new-host-detail-page-feedback/25281/20 shows Nothing Found!
. Is that a bug or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bug, it was supposed to be a header
not a title
, I've fixed that, and used action
instead of description
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @ekohl ! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amirfefer ! 👍
CP 7.0: 21c10a0 |
This PR adds a button for assigning roles when the roles page is empty