Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #34911 - prevent reset to initial roles values in EditRolesForm #533

Merged
merged 1 commit into from May 12, 2022
Merged

Fixes #34911 - prevent reset to initial roles values in EditRolesForm #533

merged 1 commit into from May 12, 2022

Conversation

Ron-Lavi
Copy link
Member

after a redux store update, the useEffect in the
EditRolesForm caused to reset back to the initial values.

@Ron-Lavi
Fixes #34911 - prevent reset to initial roles values in EditRolesForm
f556492 
after a redux store update, the useEffect in the
EditRolesForm caused to reset back to the initial values.
@stejskalleos
Copy link
Contributor

✔️ LGTM, works as expected.

Thanks @Ron-Lavi !

@stejskalleos stejskalleos merged commit 95a5fca into theforeman:master May 12, 2022
Ron-Lavi added a commit to Ron-Lavi/foreman_ansible that referenced this pull request Jul 11, 2022
@Ron-Lavi
Fixes #34911 - prevent reset to initial roles values in EditRolesForm (…
72bf50b 
…theforeman#533)

after a redux store update, the useEffect in the
EditRolesForm caused to reset back to the initial values.

(cherry picked from commit 95a5fca)
@Ron-Lavi Ron-Lavi mentioned this pull request Jul 11, 2022
Closed
Ron-Lavi added a commit to Ron-Lavi/foreman_ansible that referenced this pull request Jul 13, 2022
@Ron-Lavi
Fixes #34911 - prevent reset to initial roles values in EditRolesForm (…
88464ba 
…theforeman#533)

after a redux store update, the useEffect in the
EditRolesForm caused to reset back to the initial values.

(cherry picked from commit 95a5fca)
stejskalleos pushed a commit that referenced this pull request Jul 15, 2022
@Ron-Lavi @stejskalleos
Fixes #34911 - prevent reset to initial roles values in EditRolesForm (…
77df91b 
…#533)

after a redux store update, the useEffect in the
EditRolesForm caused to reset back to the initial values.

(cherry picked from commit 95a5fca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
3 participants
@Ron-Lavi @stejskalleos @theforeman-bot