Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35100 - disable submit if no changes in roles edit #542

Closed
wants to merge 2 commits into from
Closed

Fixes #35100 - disable submit if no changes in roles edit #542

wants to merge 2 commits into from

Conversation

Ron-Lavi
Copy link
Member

Cherry-pick for #537 which also needed #533

Ron-Lavi and others added 2 commits July 11, 2022 18:57
@Ron-Lavi
Fixes #34911 - prevent reset to initial roles values in EditRolesForm (…
72bf50b 
…theforeman#533)

after a redux store update, the useEffect in the
EditRolesForm caused to reset back to the initial values.

(cherry picked from commit 95a5fca)
@Ron-Lavi
Fixes #35100 - disable submit if no changes in roles edit (theforeman…
6213710 
…#537)

also adjusting the edit roles modal's width to 50% instead of 70%

(cherry picked from commit 2d4f240)
@Ron-Lavi
Copy link
Member Author

@stejskalleos can you take a look? thanks

@Ron-Lavi
Copy link
Member Author

Closing it, this CP should go to the 7.1-stable branch that we will create soon.

@Ron-Lavi Ron-Lavi closed this Jul 13, 2022
@Ron-Lavi
Copy link
Member Author

Continued in #543
Released in 7.1.1: https://github.com/theforeman/foreman_ansible/releases/tag/v7.1.1
RPM: theforeman/foreman-packaging#8229
DEB: theforeman/foreman-packaging#8230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed Waiting on contributor
Projects
None yet
Milestone
No milestone
2 participants
@Ron-Lavi @theforeman-bot