Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35100 - disable submit if no changes in roles edit #537

Merged
merged 1 commit into from Jul 7, 2022
Merged

Fixes #35100 - disable submit if no changes in roles edit #537

merged 1 commit into from Jul 7, 2022

Conversation

Ron-Lavi
Copy link
Member

also adjusting the edit roles modal's width to 50% instead of 70%

@Ron-Lavi
Copy link
Member Author

@stejskalleos could you take a look at this one?

@stejskalleos stejskalleos self-assigned this Jun 29, 2022
@Ron-Lavi Ron-Lavi force-pushed the 35100 branch 2 times, most recently from 999a702 to ed30bc3 Compare June 30, 2022 08:58
stejskalleos
stejskalleos requested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another issue:

  • Assign three roles to the host and save
  • Go back to Edit roles modal
  • Change order of assigned roles >> Button is still disabled

@stejskalleos stejskalleos mentioned this pull request Jul 4, 2022
Merged
@Ron-Lavi
Fixes #35100 - disable submit if no changes in roles edit
3f1b6c9 
also adjusting the edit roles modal's width to 50% instead of 70%
@Ron-Lavi
Copy link
Member Author

Ron-Lavi commented Jul 4, 2022

Thanks for double-checking @stejskalleos !
can you try again?

stejskalleos
stejskalleos approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM, works as expected.
Thanks @Ron-Lavi !

@stejskalleos stejskalleos merged commit 2d4f240 into theforeman:master Jul 7, 2022
Ron-Lavi added a commit to Ron-Lavi/foreman_ansible that referenced this pull request Jul 11, 2022
@Ron-Lavi
Fixes #35100 - disable submit if no changes in roles edit (theforeman…
6213710 
…#537)

also adjusting the edit roles modal's width to 50% instead of 70%

(cherry picked from commit 2d4f240)
@Ron-Lavi Ron-Lavi mentioned this pull request Jul 11, 2022
Closed
Ron-Lavi added a commit to Ron-Lavi/foreman_ansible that referenced this pull request Jul 13, 2022
@Ron-Lavi
Fixes #35100 - disable submit if no changes in roles edit (theforeman…
508828c 
…#537)

also adjusting the edit roles modal's width to 50% instead of 70%

(cherry picked from commit 2d4f240)
stejskalleos pushed a commit that referenced this pull request Jul 15, 2022
@Ron-Lavi @stejskalleos
Fixes #35100 - disable submit if no changes in roles edit (#537)
d51649d 
also adjusting the edit roles modal's width to 50% instead of 70%

(cherry picked from commit 2d4f240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stejskalleos stejskalleos stejskalleos approved these changes

Assignees

@stejskalleos stejskalleos

Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@Ron-Lavi @stejskalleos @theforeman-bot