Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36473 - Add missing ouia-ids #639

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fixes #36473 - Add missing ouia-ids #639

merged 1 commit into from
Jun 7, 2023

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Jun 6, 2023

@adamruzicka
Copy link
Contributor

LGTM, but there's a conflict

@MariaAga
Copy link
Member Author

MariaAga commented Jun 6, 2023

Thanks, fixed the conflict

adamruzicka
adamruzicka reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stejskalleos any idea about the test failures? JS-only changes surely cannot make the ruby tests fail, right?

@nofaralfasi
Copy link
Contributor

@stejskalleos any idea about the test failures? JS-only changes surely cannot make the ruby tests fail, right?

I don't see any test failures...

@stejskalleos
Copy link
Contributor

I re-rerun the tests, it's the issue I talked about, for some reason tests are failing on fresh DB,
something with Dynflow, not sure what.

stejskalleos
stejskalleos approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@stejskalleos stejskalleos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM

@stejskalleos stejskalleos merged commit 43acbf0 into theforeman:master Jun 7, 2023
@stejskalleos
Copy link
Contributor

thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka left review comments

@stejskalleos stejskalleos stejskalleos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MariaAga @adamruzicka @nofaralfasi @stejskalleos @theforeman-bot