New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36469 - Fix Ansible Roles and Variables sub-tabs pagination #678
base: master
Are you sure you want to change the base?
Conversation
Clicking the "Next" icon on the Roles tab alters the displayed item count when moving between page. Update: |
@nofaralfasi Hey, can you check again? |
The |
Now, both tabs are working well. |
@nofaralfasi I am having a real difficulty to solve those tests that are failing.. |
I have some tests failing also on master branch btw, @Ron-Lavi Can you open a separate pr for those tests? |
for visibility, not sure I will have much time to continue work on this PR soon, in case you want to continue from here.. |
183e452
to
d27cd39
Compare
Remove the hardcoded keys param
Since there is no easy way to do pagination with Graphql at the moment,
we are using
first
andlast
variables in the query.to make the pagination work on tables where
page * per_page > totalCount
,we needed to add the following calculation for the
last
variable