Fixes #36469 - fix React tests

theforeman · Jan 1, 2024 · cff3098 · cff3098
1 parent cb40128
commit cff3098
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/index.js b/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/index.js
@@ -17,6 +17,9 @@ const AnsibleVariableOverrides = ({ hostId, hostAttrs, history }) => {
   const hostGlobalId = encodeId('Host', hostId);
   const pagination = useCurrentPagination(history);
   const [totalItems, setTotalItems] = useState(0);
+  const setTotalCount = totalCount => {
+    if (totalCount === 0) setTotalItems(totalCount);
+  }
 
   const useFetchFn = () =>
     useQuery(variableOverrides, {
@@ -31,7 +34,8 @@ const AnsibleVariableOverrides = ({ hostId, hostAttrs, history }) => {
 
   const renameData = data => {
     const { totalCount } = data.host.ansibleVariablesWithOverrides;
-    if (totalItems === 0) setTotalItems(totalCount);
+    // Moved into a seperate function after React complained on setstate-in-render issue.
+    setTotalCount(totalCount)
     return {
       variables: data.host.ansibleVariablesWithOverrides.nodes,
       totalCount,