-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #10773 - rename ConfigTemplate to ProvisioningTemplate #14
Conversation
Replaces #13? |
ouch yes, I failed to spot it since the redmine issue was still in new state (wrong ticket number in #13), anyway this renames it hopefully on all places |
@@ -1,12 +1,16 @@ | |||
class ChangeTemplatekindToBootdisk < ActiveRecord::Migration | |||
class FakeConfigTemplate < ActiveRecord::Base | |||
self.table_name = 'config_templates' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd bet this fails tests for the same reason mentioned in https://github.com/theforeman/foreman_bootdisk/pull/13/files#r32195063.
It's a bit tricky since the ordering of DB migrations from plugins is going to depend on whether they're run together or separately. Both are valid.
5c35135
to
12e7caa
Compare
how about this? (not sure why it was aborted) |
Looks good. Abort was one of the integration tests running on an especially slow slave. Could you add the min version to engine.rb and README please? |
12e7caa
to
9bbf423
Compare
9bbf423
to
f880026
Compare
So I added new version to README, I suppose someone will have to do the release. |
Fixes #10773 - rename ConfigTemplate to ProvisioningTemplate
Yep, I'll do that soon. Thanks @ares. |
No description provided.