possibility to change the default operator for regexp #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay in replying, life's been crazy and I've let this plugin rot for too long :) |
GregSutcliffe
suggested changes
Jul 25, 2017
| if Setting[:use_and_operator] == true | ||
| true | ||
| else | ||
| false |
There was a problem hiding this comment.
Since you're saying if true, return true, then this can be simplified to just
return Setting[:use_and_operator]
That avoids the if block entirely.
| if Setting[:use_and_operator] == true | ||
| return false if not Regexp.new(fact_regex).match(host_fact_value) | ||
| else | ||
| return true if Regexp.new(fact_regex).match(host_fact_value) |
There was a problem hiding this comment.
Would be nice if we could simplify this block a bit... I'll have a think.
| # Set the defaults | ||
| Setting[:force_hostgroup_match] = false | ||
| Setting[:force_hostgroup_match_only_new] = true | ||
| Setting[:force_host_environment] = true | ||
| Setting[:use_and_operator] = false |
There was a problem hiding this comment.
This will ensure the "OR" code is still tested, but are you able to add tests for the "AND" case?
|
I appologize, this plugin has not been maintained for a long time. Given it has now conflicts, I'm closing. I'll try to find an active maintainer, please consider reopening after the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the possibility to use the AND operator for affect the default group.