Fixes #8422 - primary detection for non-discovered #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test would be good to prevent regressions, as this is modifying core. |
We injected discovery way to chose primary interface to puppet fact parser that is used also for not discovered host which are missing discovery specific facts. Mac for such value was evaluated to nil which matched also macaddress_lo so lo was chosen as primary interface.
ares
force-pushed
the
fix/8422-primary_interface_detection_only_for_discovered
branch
from
e87ef22
to
ed5f252
Compare
|
I added tests and fixed the same error in primary interface detection (also covered by tests) |
|
Test failures appear to be due to theforeman/foreman@eaefbec, which I logged against core as http://projects.theforeman.org/issues/8456. |
|
[test] |
|
Tests are now passing. Looks correct I think 👍 |
|
tested, fixes the bug for me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We injected discovery way to chose primary interface to puppet fact
parser that is used also for not discovered host which are missing
discovery specific facts. Mac for such value was evaluated to nil
which matched also macaddress_lo so lo was chosen as primary
interface.