Fixes #11708 - removed auto_provisioning RABL, improved unit tests #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mean @orrabin |
| @@ -154,6 +160,8 @@ def auto_provision_all | |||
| errors = discovered_host.errors.full_messages.join(' ') | |||
| logger.warn "Failed to auto provision host %s: %s" % [discovered_host.name, errors] | |||
| overall_errors << "#{discovered_host.name}: #{errors} " | |||
| else | |||
| total_count = total_count + 1 | |||
lzap
force-pushed
the
rabl-removal-11708
branch
from
f334977
to
5b111bd
Compare
|
Amended, please merge as this blocks our unit tests on |
|
I hope I can skip "Waiting for stable build of 'test_plugin_foreman_discovery_develop'" with [test]. Let's see. @orrabin can you merge this with a priority please? Thanks! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the RABL files are useless for auto_provison actions as we only
check HTTP code in the CLI and there is no need to render any info. More info
in the issue.
I also improved our unit tests, removed skipped test and added
refutekeywordto tests where we expect failures actually (we test ERB in these).
@orabin ?