Fixes #17648 - Added support for attributes inheritance #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok UI works, tests are passing locally, but can you add new test to check the update methods in both UI and API? Adding also a test for UI edit method would be great too. This is very fragile code with regressions :-( |
|
CLI works too nice! |
|
Tests added |
lzap
reviewed
Dec 14, 2016
| assert_equal hostgroup.medium_id, actual.medium_id | ||
| assert_equal hostgroup.ptable_id, actual.ptable_id | ||
| assert_equal hostgroup.domain_id, actual.domain_id | ||
| end |
There was a problem hiding this comment.
Mind to extend this with three more fields - environment, puppet and ca? We had similar issues in the past with these too. It's optional, I buy it just like that too :-)
lzap
reviewed
Dec 14, 2016
| assert_equal hostgroup.operatingsystem_id, actual.operatingsystem_id | ||
| assert_equal hostgroup.medium_id, actual.medium_id | ||
| assert_equal hostgroup.ptable_id, actual.ptable_id | ||
| assert_equal hostgroup.domain_id, actual.domain_id |
Changed HostConverter.to_managed to automatically call attribute inheritance mechanism when a new set of attributes is introduced.
|
Extra checks added |
|
You are hero! Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed HostConverter.to_managed to automatically call attribute inheritance mechanism when a new set of attributes is introduced.